chore: upgrading cacheable and @cacheable/net#128
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #128 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 477 477
Branches 99 95 -4
=========================================
Hits 477 477 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
This pull request updates the @cacheable/net and cacheable dependencies, which triggers several transitive updates in the lockfile. The review identifies a version mismatch where the updated undici package requires a newer Node.js engine than currently specified in package.json. Additionally, there is a recommendation to deduplicate the hookified package versions to maintain a cleaner dependency tree.
|
|
||
| undici@7.22.0: | ||
| resolution: {integrity: sha512-RqslV2Us5BrllB+JeiZnK4peryVTndy9Dnqq62S3yYRRTj0tFQCwEniUy2167skdGOy3vqRzEvl1Dm4sV2ReDg==} | ||
| undici@7.24.7: |
There was a problem hiding this comment.
The updated undici version (7.24.7) requires Node.js >=20.18.1, as specified in its engines field. However, the package.json (line 33) currently allows Node.js >=20.12.0. This mismatch may lead to installation warnings or runtime compatibility issues for users on older Node.js 20.x versions. Please update the engines.node field in package.json to at least 20.18.1.
| hookified@2.1.0: | ||
| resolution: {integrity: sha512-ootKng4eaxNxa7rx6FJv2YKef3DuhqbEj3l70oGXwddPQEEnISm50TEZQclqiLTAtilT2nu7TErtCO523hHkyg==} | ||
|
|
||
| hookified@2.1.1: |
There was a problem hiding this comment.
The lockfile now contains both hookified@2.1.0 (as a direct dependency) and hookified@2.1.1 (as a transitive dependency via qified). Since the package.json specifies ^2.1.0, these versions should be deduplicated to maintain a clean dependency tree and reduce bundle size. You can resolve this by running pnpm update hookified or pnpm dedupe.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
chore: upgrading cacheable and @cacheable/net