Skip to content

chore: upgrading cacheable and @cacheable/net#128

Merged
jaredwray merged 1 commit intomainfrom
chore-upgrading-cacheable-and-@cacheable/net
Apr 13, 2026
Merged

chore: upgrading cacheable and @cacheable/net#128
jaredwray merged 1 commit intomainfrom
chore-upgrading-cacheable-and-@cacheable/net

Conversation

@jaredwray
Copy link
Copy Markdown
Contributor

@jaredwray jaredwray commented Apr 13, 2026

Please check if the PR fulfills these requirements

  • Followed the Contributing guidelines and Code of Conduct
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
chore: upgrading cacheable and @cacheable/net

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (326143b) to head (12e2726).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #128   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          477       477           
  Branches        99        95    -4     
=========================================
  Hits           477       477           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jaredwray jaredwray merged commit 02446d8 into main Apr 13, 2026
9 checks passed
@jaredwray jaredwray deleted the chore-upgrading-cacheable-and-@cacheable/net branch April 13, 2026 09:45
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the @cacheable/net and cacheable dependencies, which triggers several transitive updates in the lockfile. The review identifies a version mismatch where the updated undici package requires a newer Node.js engine than currently specified in package.json. Additionally, there is a recommendation to deduplicate the hookified package versions to maintain a cleaner dependency tree.

Comment thread pnpm-lock.yaml

undici@7.22.0:
resolution: {integrity: sha512-RqslV2Us5BrllB+JeiZnK4peryVTndy9Dnqq62S3yYRRTj0tFQCwEniUy2167skdGOy3vqRzEvl1Dm4sV2ReDg==}
undici@7.24.7:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The updated undici version (7.24.7) requires Node.js >=20.18.1, as specified in its engines field. However, the package.json (line 33) currently allows Node.js >=20.12.0. This mismatch may lead to installation warnings or runtime compatibility issues for users on older Node.js 20.x versions. Please update the engines.node field in package.json to at least 20.18.1.

Comment thread pnpm-lock.yaml
hookified@2.1.0:
resolution: {integrity: sha512-ootKng4eaxNxa7rx6FJv2YKef3DuhqbEj3l70oGXwddPQEEnISm50TEZQclqiLTAtilT2nu7TErtCO523hHkyg==}

hookified@2.1.1:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The lockfile now contains both hookified@2.1.0 (as a direct dependency) and hookified@2.1.1 (as a transitive dependency via qified). Since the package.json specifies ^2.1.0, these versions should be deduplicated to maintain a clean dependency tree and reduce bundle size. You can resolve this by running pnpm update hookified or pnpm dedupe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant