chore: migrating to tsdown and upgrading typescript#36
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates the project's build system from tsup to tsdown, updates the package.json exports and entry points to use explicit .mjs and .cjs extensions, and upgrades TypeScript to version 6.0.2. Feedback was provided regarding a discrepancy in the lockfile where the TypeScript version specifier is pinned to a fixed version, which conflicts with the caret range defined in package.json and prevents automatic minor or patch updates.
| typescript: | ||
| specifier: ^5.9.3 | ||
| version: 5.9.3 | ||
| specifier: 6.0.2 |
There was a problem hiding this comment.
The specifier for the typescript dependency is pinned to 6.0.2 in the lockfile, but package.json uses ^6.0.2. This prevents automatic patch and minor version updates for TypeScript. To ensure non-breaking updates are applied, the specifier in the lockfile should match the one in package.json.
Running pnpm install after ensuring package.json is correct should fix this.
specifier: ^6.0.2![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e10a5dd56b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| typescript: | ||
| specifier: ^5.9.3 | ||
| version: 5.9.3 | ||
| specifier: 6.0.2 |
There was a problem hiding this comment.
pnpm-lock.yaml now records typescript with specifier 6.0.2, but package.json declares ^6.0.2; this makes the lockfile stale and pnpm install fails with ERR_PNPM_OUTDATED_LOCKFILE when frozen-lockfile is enabled (which is the default in CI). In this repo, the workflows run plain pnpm install, so this mismatch can block test/release jobs until the lockfile is regenerated (or the manifest range is made exact).
Useful? React with 👍 / 👎.
jaredwray
deleted the
chore-migrating-to-tsdown-and-upgrading-typescript
branch
1 participant
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
chore: migrating to tsdown and upgrading typescript