chore: migrating to tsdown and upgrading typescript#37
Conversation
There was a problem hiding this comment.
Code Review
This pull request migrates the build system from tsup to tsdown, upgrades TypeScript to version 6.0.2, and updates the package version to 1.2.0. The package exports have been refined to support dual-module formats with explicit type definitions for ESM and CJS. I have no feedback to provide.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 19 19
Branches 1 1
=========================================
Hits 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9ea0da3fb3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "build": "tsdown", | ||
| "clean": "rimraf ./dist pnpm-lock.yaml node_modules coverage", | ||
| "prepare": "pnpm build" | ||
| "prepublishOnly": "pnpm build" |
There was a problem hiding this comment.
Restore prepare build hook for git/local installs
Replacing prepare with prepublishOnly means the build no longer runs when this package is installed from a git URL or local path, because npm/pnpm only run prepublishOnly on publish while prepare runs before packing/installing git dependencies. Since this repo does not commit dist/ but package entry points (main/exports) all target dist/*, those install paths now produce an unbuilt package that fails at runtime with missing module files.
Useful? React with 👍 / 👎.
No description provided.