Fix edge subgraph#176
Merged
Merged
Conversation
Co-authored-by: Matt Fishman <mtfishman@users.noreply.github.com>
Co-authored-by: Matt Fishman <mtfishman@users.noreply.github.com>
Co-authored-by: Matt Fishman <mtfishman@users.noreply.github.com>
Co-authored-by: Matt Fishman <mtfishman@users.noreply.github.com>
Co-authored-by: Matt Fishman <mtfishman@users.noreply.github.com>
…aphs.jl into mf/partitionsgraphview
PartitionsGraphView update
for more information, see https://pre-commit.ci
Member
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
…into Fix_Edge_Subgraph
mtfishman
reviewed
Jul 8, 2026
Collaborator
Author
|
@mtfishman This is good to merge on my end. I don't understand what the downstream ITensorNetworks test fail is, seems like something to do with |
Member
Sorry for the delay, this is good to go from my end but I wanted to look into that before merging, not sure what's going on there. (Looks like it was a temporary glitch using some incompatible package versions.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes Issue #175 by defining
edge_subgraph(g, edgelist)separately for theNamedGraphandNamedDiGraphtypes, which should behave differently because one cares about the direction of edges in the latter but not in the former.