Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR improves incremental generator verification by naming the incremental pipeline step and enhancing the test helper to assert incrementality based on tracked step names.
Changes:
- Added
WithTrackingName("ValidationClasses")to the generator pipeline to surface a stable tracked-step name in Roslyn incremental run results. - Refactored
GeneratorTestHelper.RunGeneratorto run once for the returned result and separately verify incrementality on a cloned compilation. - Introduced step-name–based incrementality assertions with support for “skipped” steps.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/Immediate.Validations.Tests/GeneratorTests/GeneratorTestHelper.cs | Refactors generator execution and adds a named-step incrementality verification routine. |
| src/Immediate.Validations.Generators/ImmediateValidationsGenerator.cs | Adds a tracking name to the validations incremental pipeline step for better incrementality diagnostics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.