minor grammar changes.#2
Merged
Merged
Conversation
Other suggestions: in functions.md section 2.3 the ## methods section code block is the first time .v is mentioned. It is not explained. Do we expect new readers to know that it is indended for Rocq proof assistant? in assertions.md section 4.3 I believe is the first mention of Rocq, without an explanation. These are both referenced in the appendix but I think it could be confusing for someone who is instructed to read the book from start to finish in order, if we present some of the information like Rocq and .v files near the end of the book
0xGeorgii
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Other suggestions:
in functions.md section 2.3 the ## methods section, the code block is the first time .v is mentioned. It is not explained. Do we expect new readers to know that it is intended for Rocq proof assistant?
in assertions.md section 4.3 I believe is the first mention of Rocq, without an explanation.
These are both referenced in the appendix but I think it could be confusing for someone who is instructed to read the book from start to finish in order, if we present some of the information like Rocq and .v files near the end of the book