feat: support puma run#55
Merged
Merged
Conversation
Signed-off-by: kerthcet <kerthcet@gmail.com>
InftyAI-Agent
added
needs-triage
There was a problem hiding this comment.
Pull request overview
This PR introduces a provider abstraction for model downloads and wires it into the CLI, including a new puma run subcommand that can download a model when it’s missing locally.
Changes:
- Added a
Providerenum and adownloader::download_model(...)helper to centralize provider-specific download logic. - Updated
puma pullto use the new download helper (and provider enum fromdownloader). - Added
puma run <model> [-p <provider>]to check the registry and download the model if needed (execution still TODO).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/downloader/mod.rs | Adds provider enum and a unified download_model entrypoint. |
| src/cli/commands.rs | Refactors pull to use the new downloader API and adds the run subcommand/args. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
/lgtm |
InftyAI-Agent
added
lgtm
InftyAI-Agent
approved these changes
Jul 5, 2026
InftyAI-Agent
left a comment
InftyAI-Agent
left a comment
Member
There was a problem hiding this comment.
Approved: PR has both lgtm and approved labels
Comment on lines
+175
to
+178
| // RUN command requires a model argument | ||
| let output = run_puma(home, &["run", "test/model"]); | ||
| // Will fail because test/model doesn't exist on HuggingFace, but at least it attempts | ||
| assert!(output_contains(&output, "not found locally") || output_contains(&output, "Error")); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #
Special notes for your reviewer
Does this PR introduce a user-facing change?