COMP: Pin the clang-format linter action and the ITK revision it reads - #5
Merged
Merged
Conversation
The linter ran InsightSoftwareConsortium/ITKClangFormatLinterAction@main and read ITK's main for the clang-format version, the style and the runner. A change in either changes what the check requires without a change here: the action started to require a .gitattributes on 2026-09-29, which turned the check red on a pull request that had not touched the style. Both are pinned to the commits the check passes with today (clang-format 19.1.7).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The clang-format check ran
ITKClangFormatLinterAction@mainand read ITK'smainfor the clang-format version, the style and the runner script. A change in either changes what the check requires without any change in this repository: the action started to require a.gitattributeson 2026-09-29, which turned the check red on a pull request that had not touched the style.Both are now pinned to the commits the check passes with today:
fc9d686(itsmainof 2026-09-29);5d31af3(itsmainof 2026-10-01, clang-format 19.1.7).Moving to a newer style is then a deliberate change of these two lines.