Skip to content

Improve descriptions for some device object fields and add a new field called code#166

Open
jwrosewell wants to merge 3 commits into
InteractiveAdvertisingBureau:developfrom
51Degrees:develop
Open

Improve descriptions for some device object fields and add a new field called code#166
jwrosewell wants to merge 3 commits into
InteractiveAdvertisingBureau:developfrom
51Degrees:develop

Conversation

@jwrosewell

Copy link
Copy Markdown
  1. Circular definitions are removed. i.e. field name is no longer used in the description.
  2. Clarifies the difference between the well-known marketing name and the manufacturer's provided model code. i.e. GLBW0 for Pixel 10.
  3. Introduces the word “series” to explain the difference between model and hmv with examples to show the different values.
  4. Expands the examples to include more modern devices from a broader range of vendors.

1. Circular definitions are removed. i.e. field name is no longer used in the description.
2. Clarifies the difference between the well-known marketing name and the manufacturer's provided model code. i.e. `GLBW0` for Pixel 10.
3. Introduces the word “series” to explain the difference between `model` and `hmv` with examples to show the different values.
4. Expands the examples to include more modern devices from a broader range of vendors.
@ollyburns

Copy link
Copy Markdown

+1

Expanded description examples to include a TV and Mediahub.
@ChrisBasis

Copy link
Copy Markdown
Contributor

+1

1 similar comment
@vasujain00

Copy link
Copy Markdown

+1

Comment thread 2.6.md Outdated
Comment thread 2.6.md Outdated
@piyushThinkNear

Copy link
Copy Markdown

+1

@piyushThinkNear piyushThinkNear left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants