Skip to content

Fix: issues#22

Merged
ItzNotABug merged 4 commits intomasterfrom
fix-issues
Feb 6, 2026
Merged

Fix: issues#22
ItzNotABug merged 4 commits intomasterfrom
fix-issues

Conversation

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request attempts to fix two issues related to URI handling in the DocumentFileCompat library:

Changes:

  • Added validation in SingleDocumentFileCompat to reject tree URIs and non-document URIs (fixes issue #19)
  • Modified TreeDocumentFileCompat to preserve existing document URI paths instead of discarding subdirectories (fixes issue #21)
  • Refactored isTreeUri method from TreeDocumentFileCompat to DocumentFileCompat as an internal helper method

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
dfc/src/main/java/com/lazygeniouz/dfc/file/internals/TreeDocumentFileCompat.kt Removed private isTreeUri method; added check to preserve document URI structure when already present
dfc/src/main/java/com/lazygeniouz/dfc/file/internals/SingleDocumentFileCompat.kt Added validation to reject tree URIs and non-document URIs before processing
dfc/src/main/java/com/lazygeniouz/dfc/file/DocumentFileCompat.kt Added isTreeUri as internal method in companion object for shared use

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ItzNotABug ItzNotABug merged commit 79f0c7e into master Feb 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant