Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request attempts to fix two issues related to URI handling in the DocumentFileCompat library:
Changes:
- Added validation in
SingleDocumentFileCompatto reject tree URIs and non-document URIs (fixes issue #19) - Modified
TreeDocumentFileCompatto preserve existing document URI paths instead of discarding subdirectories (fixes issue #21) - Refactored
isTreeUrimethod fromTreeDocumentFileCompattoDocumentFileCompatas an internal helper method
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| dfc/src/main/java/com/lazygeniouz/dfc/file/internals/TreeDocumentFileCompat.kt | Removed private isTreeUri method; added check to preserve document URI structure when already present |
| dfc/src/main/java/com/lazygeniouz/dfc/file/internals/SingleDocumentFileCompat.kt | Added validation to reject tree URIs and non-document URIs before processing |
| dfc/src/main/java/com/lazygeniouz/dfc/file/DocumentFileCompat.kt | Added isTreeUri as internal method in companion object for shared use |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dfc/src/main/java/com/lazygeniouz/dfc/file/internals/SingleDocumentFileCompat.kt
Show resolved
Hide resolved
dfc/src/main/java/com/lazygeniouz/dfc/file/internals/TreeDocumentFileCompat.kt
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses -
TreeDocumentFileCompat.makediscards subdirectories if uri is already a document URI #21