Draft
Conversation
- Add GridOrientationConfig and GridConfig types to store/types.ts - Add gridConfig defaults (landscape: 4x2, portrait: 2x4) to appState.ts - Update test fixtures to include the new gridConfig property Co-authored-by: Abasz <32517724+Abasz@users.noreply.github.com>
Add slotContent parameter to all metric template functions in dashboardMetrics.ts and the simpleMetricFactory helper. Restructure DashboardMetric render to use CSS classes (with-icon) instead of inline styles, and move slot inside the icon/label div. Add :host positioning to BatteryIcon. Add :host grid-column span and slot support to DashboardForceCurve. Update DashboardMetric tests for new class-based rendering. Co-authored-by: Abasz <32517724+Abasz@users.noreply.github.com>
- Add retile/submit toggle button with active state styling. - Add reset-to-default button (visible only in retile mode). - Move settings dialog ownership to parent via open-settings event. - Add toggleRetileMode and resetToDefault methods that dispatch custom events for PerformanceDashboard to handle. Co-authored-by: Abasz <32517724+Abasz@users.noreply.github.com>
- Replace fixed grid layout with CSS custom properties (--grid-columns, --grid-rows) driven by gridConfig from app state. - Add retile mode state management: local metrics copy on enter, save via changeGuiSetting on submit, reset-to-default support. - Add metric controls (remove/replace dropdown) rendered as slot content. - Add 'add tile' panel with available metrics filtered by remaining slots. - Handle settings dialog and workout dialog from PerformanceDashboard. - Use component factory pattern returning (slotContent) => TemplateResult to support both retile controls and normal rendering. Co-authored-by: Abasz <32517724+Abasz@users.noreply.github.com>
- Make cursor:pointer and @click on distance/calories/timer tiles conditional on onWorkoutOpen being defined (not shown in retile mode) - Add stopPropagation to retile controls to prevent parent click handler from intercepting dropdown interactions - Increase retile select padding and min-width for larger click area - Add z-index to retile controls for reliable click targeting
Owner
|
Is this PR considered complete now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the continuation of #213
Technically this feature works (and the GUI works too) but there are things that are still missing: