feat: add 'create and copy' button to the neuroglancer link dialog#310
Merged
allison-truhlar merged 4 commits intomainfrom Feb 12, 2026
Merged
feat: add 'create and copy' button to the neuroglancer link dialog#310allison-truhlar merged 4 commits intomainfrom
allison-truhlar merged 4 commits intomainfrom
Conversation
neomorphic
reviewed
Feb 12, 2026
neomorphic
approved these changes
Feb 12, 2026
Member
neomorphic
left a comment
neomorphic
left a comment
There was a problem hiding this comment.
Looks good. I would consider combing the two toasts into a single statement, but it isn't necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clickup id: 86aerzhc7
This PR adds a step to the 'create' and 'update' functions of the Neuroglancer short link generation dialog, to copy the generated Neuroglancer link to the clipboard after it is successfully created on the backend. It also updates the text on the buttons to indicate that the link will be copied, and adds a toast notification that the link has been copied. Also in this PR, I updated the NGLinkPayload type to be more specific to the possible sets of data submitted through the dialog - either a URL or state data and a base URL. In both cases, an optional short name and title can also be provided.