Fix failing CI workflows + guard delisted data integrity + bump actions to Node 24#154
Merged
JerBouma merged 1 commit intoJun 4, 2026
Conversation
dokson
force-pushed
the
fix/ci-workflows-and-delisted-hardening
branch
from
19ab3de to
1678103
Compare
Owner
|
The fact delisted contains a NaN is actually a database mistake and we should catch it before allowing it to be merged instead. I believe right now the database update GitHub Actions already prevents that. I'd rather have the package fail when such a mistake is made than to allow the mistake through by changing the filtering option. |
- database_update.yml: restrict the push trigger back to `main`. Without
it the workflow ran on pushes to any branch and the commit step died on
`git checkout main` ("pathspec 'main' did not match") since no local
main exists on a non-main checkout.
- Bump all actions to Node 24 runtimes across the three workflows
(checkout v6, setup-python v6, setup-uv v7, run-python-script-action
v1.8), clearing the Node 20 deprecation warning.
- Add a cross-asset invariant asserting equities `delisted` is strictly
bool, so a NaN (which breaks `~equities["delisted"]`) fails CI before
merge instead of being silently filtered.
dokson
force-pushed
the
fix/ci-workflows-and-delisted-hardening
branch
from
1678103 to
095fe92
Compare
dokson
changed the title
Contributor
Author
|
Reverted the filter change. Heads up though: |
Owner
|
That's perfect, if there is still a NaN in there I'll take it out manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
database_update.yml: restore thepushbranch filter tomain. It was running on every branch, and the commit step failed ongit checkout main(pathspec 'main' did not match) on non-main checkouts.checkout@v6,setup-python@v6,setup-uv@v7,run-python-script-action@v1.8— clears the Node 20 deprecation.tests/test_invariants.py: invariant asserting equitiesdelistedis strictlybool, so a NaN (which breaks~equities["delisted"]) fails CI before merge.Note
Per review feedback, the library filter is left untouched — bad
delisteddata should fail loudly. The invariant catches it at the data layer instead. Related: #153.