Skip to content

Raise minimum Julia version to 1.6#366

Merged
willow-ahrens merged 3 commits into
JuliaCI:masterfrom
Zentrik:patch-3
May 2, 2024
Merged

Raise minimum Julia version to 1.6#366
willow-ahrens merged 3 commits into
JuliaCI:masterfrom
Zentrik:patch-3

Conversation

@Zentrik

@Zentrik Zentrik commented Apr 26, 2024

Copy link
Copy Markdown
Contributor

Split out from #347, LinuxPerf doesn't support 1.0 as it depends on PrettyTables which doesn't. Also, buildkite doesn't seem to support it either.
1.0 seems sufficiently old that it seems fine to me to drop support.

@Zentrik Zentrik mentioned this pull request Apr 26, 2024

@willow-ahrens willow-ahrens left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, revising my earlier comment. shouldn't these 5 lines just read the package toml? Otherwise we would need to update this version every time.

@willow-ahrens willow-ahrens left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's take this opportunity to remove a hard-coded version string

Comment thread src/BenchmarkTools.jl Outdated
@willow-ahrens willow-ahrens merged commit 0941fd1 into JuliaCI:master May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants