Fix UndefVarError in merge_nonunique_inputs warning#144
Merged
Conversation
The warning strings interpolated `$(u[i])` but `u` is not defined inside `merge_nonunique_inputs(sys)`. When the warning condition fires (overlapping non-zero entries between B/D columns merged under the same input name) the @warn would raise UndefVarError instead of issuing the documented warning. Use the local `inputnames[i]` instead, and add a regression test that constructs a system with overlapping B columns under a duplicated input name and asserts the warning is emitted. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #144 +/- ##
=======================================
Coverage 91.84% 91.84%
=======================================
Files 20 20
Lines 3064 3064
=======================================
Hits 2814 2814
Misses 250 250
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@warncalls inmerge_nonunique_inputsinterpolated$(u[i]), butuis not defined inside that function. When the warning condition fires (overlapping non-zero entries between B/D columns being merged under the same input name) the result was anUndefVarError, not the documented warning.inputnames[i]instead, and add a regression test intest_named_systems2.jl.Test plan
test_named_systems2.jltests still pass locally.🤖 Generated with Claude Code