Skip to content

prepare deprecation of simple and alternative#507

Open
jverzani wants to merge 14 commits into
JuliaMath:masterfrom
jverzani:fzero
Open

prepare deprecation of simple and alternative#507
jverzani wants to merge 14 commits into
JuliaMath:masterfrom
jverzani:fzero

Conversation

@jverzani

@jverzani jverzani commented Apr 22, 2026

Copy link
Copy Markdown
Member

This PR does:

  • streamlines fzero
  • separates out code and tests for alternative_interfaces and simple. (some goes into find_zeros)
  • prepares deprecation warnings for functions in alternative_interfaces and simple (but doesn't uncomment them yet)
  • add modab code to simple, as it was contributed and might be of independent interest

The goal is to deprecate the two files, both could be elsewhere, especially alternative interfaces which has had comments about it being legacy for years now.

@codecov

codecov Bot commented Apr 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 74.72924% with 70 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.07%. Comparing base (a45a34f) to head (f605ae7).
⚠️ Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
src/deprecated/simple.jl 14.49% 59 Missing ⚠️
src/Bracketing/false_position.jl 75.00% 5 Missing ⚠️
src/Bracketing/regula_falsi.jl 93.75% 3 Missing ⚠️
src/find_zeros.jl 96.55% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #507      +/-   ##
==========================================
- Coverage   86.93%   83.07%   -3.87%     
==========================================
  Files          41       42       +1     
  Lines        2565     2670     +105     
==========================================
- Hits         2230     2218      -12     
- Misses        335      452     +117     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jverzani and others added 13 commits April 23, 2026 19:30
* logging of Sidi

* typos
* give regula falsi methods some attention; add Diaz and Perez framework

* simplify nameing

* add to docs

* typo, italics

* another typo
…gged (JuliaMath#516)

closes JuliaMath#515

* adds a check on f being close to zero for bracketing intervals that throw `:not_converged`. In an earlier PR, this was a bug as this flag was not checked at all.
* add NonStrictBracketing type

* engineer around stuck points in RegulaFalsi; clean up tests; reorganize decide_convergence
* update docs

* doc edits; better engineering on regula falsi methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants