Skip to content

cert issue fix - #844

Open
chidanandpujar wants to merge 8 commits into
Juniper:masterfrom
chidanandpujar:certfix1
Open

cert issue fix#844
chidanandpujar wants to merge 8 commits into
Juniper:masterfrom
chidanandpujar:certfix1

Conversation

@chidanandpujar

@chidanandpujar chidanandpujar commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Description

Closes # #729

certification issue fix

Collection Namespace

  • Collection namespace: juniper.device
  • Collection version (bumped to):
  • Module(s) / plugin(s) changed:

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • Feature / new module or plugin (non-breaking change that adds functionality)
  • Enhancement (improvement to existing module or plugin behaviour)
  • Breaking change (fix or feature that would cause existing playbooks / roles to behave differently)
  • Task / Chore (refactor, dependency update, CI, docs, etc.)

Fix Details

Root Cause

Solution


Versions Tested

Item Version
Collection namespace & version
Ansible / ansible-core
Python
OS
Junos version
Junos platform
junos-eznc
ncclient

Sanity Test Results

  • Sanity tests pass with no new errors
ansible-test sanity
Sanity test output
<paste sanity test output here>

Unit Test Results

  • New or updated unit tests added under tests/unit/
  • All unit tests pass locally
python3.12 -m pytest
Unit test output
<paste unit test output here>
  • Code coverage has not decreased

Integration Test Results

  • Integration tests reviewed for impact
  • Affected integration tests pass (requires a live Junos device or vMX)
ansible-test network-integration --python 3.12 --inventory /root/pyez_ansible_release_validation1/ansible-junos-stdlib/ansible_collections/juniper/device/tests/integration/inventory.networking
Integration test output
<paste integration test output here>

Checklist

Code Quality

  • Code follows the project's style guidelines
  • ansible-lint passes with no new errors
ansible-lint
  • flake8 / ruff reports no new errors (for Python files)
flake8 plugins/
# or
ruff check plugins/

Documentation

  • Module documentation (DOCUMENTATION, EXAMPLES, RETURN blocks) updated if parameters changed
  • CHANGELOG.rst / changelogs/fragments/ entry added
  • galaxy.yml version bumped if releasing

General

  • No hardcoded credentials, IP addresses, or sensitive data introduced
  • requirements.txt updated if new Python packages are required
  • Backward-compatible: existing playbooks will not break

Additional Notes

@chidanandpujar

Copy link
Copy Markdown
Collaborator Author
(venvcert) regress@masterhost:~/ansible_cert_issue_fix1/ansible-junos-stdlib/ansible_collections/juniper/device$ python3 -m galaxy_importer.main  juniper-device-2.0.2.tar.gz
Importing with galaxy-importer 0.4.40
Getting doc strings via ansible-doc
Finding content inside collection
Loading action acl_interfaces
Loading action acls
Loading action bgp_address_family
Loading action bgp_global
Loading action command
Loading action config
Loading action extract_data
Loading action facts
Loading action file_copy
Loading action hostname
Loading action interfaces
Loading action jsnapy
Loading action juniper_junos_common_action
Loading action junos
Loading action junos_banner
Loading action junos_command
Loading action junos_config
Loading action junos_facts
Loading action l2_interfaces
Loading action l3_intefaces
Loading action lacp
Loading action lacp_intefaces
Loading action lag_interfaces
Loading action lldp_global
Loading action lldp_interfaces
Loading action logging
Loading action logging_global
Loading action netconf
Loading action ntp_global
Loading action ospf_interfaces
Loading action ospfv2
Loading action ospfv3
Loading action ping
Loading action pmtud
Loading action prefix_lists
Loading action routing_instances
Loading action routing_options
Loading action rpc
Loading action security_policies
Loading action security_policies_global
Loading action security_zones
Loading action snmp_server
Loading action software
Loading action srx_cluster
Loading action static_routes
Loading action system
Loading action table
Loading callback jsnapy
Loading cliconf junos
Loading connection pyez
Loading doc_fragments juniper_junos_doc
Loading doc_fragments junos
Loading module _tbrdevice_hostname
Loading module command
Loading module config
Loading module facts
Loading module file_copy
Loading module jsnapy
Loading module junos
Loading module junos_acl_interfaces
Loading module junos_acls
Loading module junos_banner
Loading module junos_bgp_address_family
Loading module junos_bgp_global
Loading module junos_command
Loading module junos_config
Loading module junos_facts
Loading module junos_hostname
Loading module junos_interfaces
Loading module junos_l2_interfaces
Loading module junos_l3_interfaces
Loading module junos_lacp
Loading module junos_lacp_interfaces
Loading module junos_lag_interfaces
Loading module junos_lldp_global
Loading module junos_lldp_interfaces
Loading module junos_logging_global
Loading module junos_netconf
Loading module junos_ntp_global
Loading module junos_ospf_interfaces
Loading module junos_ospfv2
Loading module junos_ospfv3
Loading module junos_package
Loading module junos_ping
Loading module junos_prefix_lists
Loading module junos_routing_instances
Loading module junos_routing_options
Loading module junos_rpc
Loading module junos_security_policies
Loading module junos_security_policies_global
Loading module junos_security_zones
Loading module junos_snmp_server
Loading module junos_static_routes
Loading module junos_system
Loading module junos_user
Loading module junos_vlans
Loading module junos_vrf
Loading module ping
Loading module pmtud
Loading module rpc
Loading module software
Loading module srx_cluster
Loading module system
Loading module table
Loading module tbrdevice_facts
Loading module_utils configuration
Loading module_utils juniper_junos_common
Loading module_utils netconf_tbr.exceptions
Loading module_utils netconf_tbr.junos
Loading module_utils network.junos.argspec.acl_interfaces.acl_interfaces
Loading module_utils network.junos.argspec.acls.acls
Loading module_utils network.junos.argspec.bgp_address_family.bgp_address_family
Loading module_utils network.junos.argspec.bgp_global.bgp_global
Loading module_utils network.junos.argspec.facts.facts
Loading module_utils network.junos.argspec.hostname.hostname
Loading module_utils network.junos.argspec.interfaces.interfaces
Loading module_utils network.junos.argspec.l2_interfaces.l2_interfaces
Loading module_utils network.junos.argspec.l3_interfaces.l3_interfaces
Loading module_utils network.junos.argspec.lacp.lacp
Loading module_utils network.junos.argspec.lacp_interfaces.lacp_interfaces
Loading module_utils network.junos.argspec.lag_interfaces.lag_interfaces
Loading module_utils network.junos.argspec.lldp_global.lldp_global
Loading module_utils network.junos.argspec.lldp_interfaces.lldp_interfaces
Loading module_utils network.junos.argspec.logging_global.logging_global
Loading module_utils network.junos.argspec.ntp_global.ntp_global
Loading module_utils network.junos.argspec.ospf_interfaces.ospf_interfaces
Loading module_utils network.junos.argspec.ospfv2.ospfv2
Loading module_utils network.junos.argspec.ospfv3.ospfv3
Loading module_utils network.junos.argspec.prefix_lists.prefix_lists
Loading module_utils network.junos.argspec.routing_instances.routing_instances
Loading module_utils network.junos.argspec.routing_options.routing_options
Loading module_utils network.junos.argspec.security_policies.security_policies
Loading module_utils network.junos.argspec.security_policies_global.security_policies_global
Loading module_utils network.junos.argspec.security_zones.security_zones
Loading module_utils network.junos.argspec.snmp_server.snmp_server
Loading module_utils network.junos.argspec.static_routes.static_routes
Loading module_utils network.junos.argspec.vlans.vlans
Loading module_utils network.junos.config.acl_interfaces.acl_interfaces
Loading module_utils network.junos.config.acls.acls
Loading module_utils network.junos.config.bgp_address_family.bgp_address_family
Loading module_utils network.junos.config.bgp_global.bgp_global
Loading module_utils network.junos.config.hostname.hostname
Loading module_utils network.junos.config.interfaces.interfaces
Loading module_utils network.junos.config.l2_interfaces.l2_interfaces
Loading module_utils network.junos.config.l3_interfaces.l3_interfaces
Loading module_utils network.junos.config.lacp.lacp
Loading module_utils network.junos.config.lacp_interfaces.lacp_interfaces
Loading module_utils network.junos.config.lag_interfaces.lag_interfaces
Loading module_utils network.junos.config.lldp_global.lldp_global
Loading module_utils network.junos.config.lldp_interfaces.lldp_interfaces
Loading module_utils network.junos.config.logging_global.logging_global
Loading module_utils network.junos.config.ntp_global.ntp_global
Loading module_utils network.junos.config.ospf_interfaces.ospf_interfaces
Loading module_utils network.junos.config.ospfv2.ospfv2
Loading module_utils network.junos.config.ospfv3.ospfv3
Loading module_utils network.junos.config.prefix_lists.prefix_lists
Loading module_utils network.junos.config.routing_instances.routing_instances
Loading module_utils network.junos.config.routing_options.routing_options
Loading module_utils network.junos.config.security_policies.security_policies
Loading module_utils network.junos.config.security_policies_global.security_policies_global
Loading module_utils network.junos.config.security_zones.security_zones
Loading module_utils network.junos.config.snmp_server.snmp_server
Loading module_utils network.junos.config.static_routes.static_routes
Loading module_utils network.junos.config.vlans.vlans
Loading module_utils network.junos.facts.acl_interfaces.acl_interfaces
Loading module_utils network.junos.facts.acls.acls
Loading module_utils network.junos.facts.bgp_address_family.bgp_address_family
Loading module_utils network.junos.facts.bgp_global.bgp_global
Loading module_utils network.junos.facts.facts
Loading module_utils network.junos.facts.hostname.hostname
Loading module_utils network.junos.facts.interfaces.interfaces
Loading module_utils network.junos.facts.l2_interfaces.l2_interfaces
Loading module_utils network.junos.facts.l3_interfaces.l3_interfaces
Loading module_utils network.junos.facts.lacp.lacp
Loading module_utils network.junos.facts.lacp_interfaces.lacp_interfaces
Loading module_utils network.junos.facts.lag_interfaces.lag_interfaces
Loading module_utils network.junos.facts.legacy.base
Loading module_utils network.junos.facts.lldp_global.lldp_global
Loading module_utils network.junos.facts.lldp_interfaces.lldp_interfaces
Loading module_utils network.junos.facts.logging_global.logging_global
Loading module_utils network.junos.facts.ntp_global.ntp_global
Loading module_utils network.junos.facts.ospf_interfaces.ospf_interfaces
Loading module_utils network.junos.facts.ospfv2.ospfv2
Loading module_utils network.junos.facts.ospfv3.ospfv3
Loading module_utils network.junos.facts.prefix_lists.prefix_lists
Loading module_utils network.junos.facts.routing_instances.routing_instances
Loading module_utils network.junos.facts.routing_options.routing_options
Loading module_utils network.junos.facts.security_policies.security_policies
Loading module_utils network.junos.facts.security_policies_global.security_policies_global
Loading module_utils network.junos.facts.security_zones.security_zones
Loading module_utils network.junos.facts.snmp_server.snmp_server
Loading module_utils network.junos.facts.static_routes.static_routes
Loading module_utils network.junos.facts.vlans.vlans
Loading module_utils network.junos.junos
Loading module_utils network.junos.utils.utils
Loading netconf junos
Loading terminal junos
Linting collection via ansible-lint 26.6.0...
...ansible-lint run complete
WARNING: Ignore files skip ansible-test sanity tests, found ignore-2.21.txt with 21 statement(s)
WARNING: Ignore files skip ansible-test sanity tests, found ignore-2.16.txt with 58 statement(s)
WARNING: Ignore files skip ansible-test sanity tests, found ignore-2.20.txt with 60 statement(s)
WARNING: Ignore files skip ansible-test sanity tests, found ignore-2.17.txt with 58 statement(s)
WARNING: Ignore files skip ansible-test sanity tests, found ignore-2.18.txt with 58 statement(s)
WARNING: Ignore files skip ansible-test sanity tests, found ignore-2.19.txt with 58 statement(s)
Collection loading complete
Importer processing completed successfully

@chidanandpujar

chidanandpujar commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator Author

UT logs:

(venvcert) regress@masterhost:~/ansible_cert_issue_fix1/ansible-junos-stdlib/ansible_collections/juniper/device/tests/unit$ python3 -m pytest
======================================================== test session starts =========================================================
platform linux -- Python 3.12.0, pytest-9.1.1, pluggy-1.6.0
rootdir: /home/regress/ansible_cert_issue_fix1/ansible-junos-stdlib
collected 23 items                                                                                                                   

test_command.py .....                                                                                                          [ 21%]
test_facts.py ..                                                                                                               [ 30%]
test_file_copy.py ..........                                                                                                   [ 73%]
test_ping.py ...                                                                                                               [ 86%]
test_system.py ...                                                                                                             [100%]

========================================================= 23 passed in 0.82s =========================================================

@chidanandpujar

Copy link
Copy Markdown
Collaborator Author

sanity tests

(venvcert) regress@masterhost:~/ansible_cert_issue_fix1/ansible-junos-stdlib/ansible_collections/juniper/device/tests/sanity$ ansible-test sanity --python 3.12
Running sanity test "action-plugin-docs"
Running sanity test "ansible-doc"
Running sanity test "changelog"
Running sanity test "compile" on Python 3.12
Running sanity test "empty-init"
Running sanity test "ignores"
Running sanity test "import" on Python 3.12
Running sanity test "line-endings"
Running sanity test "no-assert"
Running sanity test "no-get-exception"
Running sanity test "no-illegal-filenames"
Running sanity test "no-smart-quotes"
Running sanity test "pep8"
Running sanity test "pslint"
Running sanity test "pylint"
Running sanity test "replace-urlopen"
Running sanity test "runtime-metadata"
Running sanity test "shebang"
Running sanity test "shellcheck"
Running sanity test "symlinks"
Running sanity test "use-argspec-type-path"
Running sanity test "use-compat-six"
Running sanity test "validate-modules"
Running sanity test "yamllint"

@chidanandpujar

Copy link
Copy Markdown
Collaborator Author

Integration tests passed

TASK [junos_z_system : Checking NETCONF connectivity] **************************
ok: [junos_test]

PLAY RECAP *********************************************************************
junos_test                 : ok=19   changed=2    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0   

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant