Fix condition to ignore TransparentFX in pr390 to fix issue #410. - #423
Fix condition to ignore TransparentFX in pr390 to fix issue #410.#423BrettRyland wants to merge 1 commit into
Conversation
|
So the problem with the original patch runs a bit deeper than what this approach will fix. The editor will occasionally put everything on the TransparentFX layer and anything that attempts to compute the bounds at that point (and possibly afterwards, not sure) will have issues. I don't think just adding the check here will work. I do have an approach that I think will work well enough, but the branch for that is on my home computer and I won't be back until later this week. I'll make a PR then. |
|
OK, good to hear that you have another approach that you think will be better. |
PR #390 introduced a condition to ignore TransparentFX when calculating part renderer bounds.
The condition used is insufficient and breaks mods that rely on those bounds for their calculations #410. E.g., BDArmory uses these as part of its hitpoint calculations when the part is created (i.e., while the part is detached).
This PR modifies the condition for when to ignore TransparentFX to take into account detached parts by checking if all parents of the part transform are on the TransparentFX layer.