Stop blocking map view part clicks before there is a camera - #427
Open
djungelorm wants to merge 1 commit into
Open
Stop blocking map view part clicks before there is a camera#427djungelorm wants to merge 1 commit into
djungelorm wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part_UpdateMouseOver_PrefixreadsCameraManager.Instance.currentCameraModeas soon asHighLogic.LoadedSceneIsFlightis true. The scene calls itself flight from the moment it starts loading, a good while before the camera manager exists, so every frame of a load into flight throws an NRE.Returning
truewhen the camera manager is missing, so that stock runs as it would unpatched, only moves the exception: stockPart.UpdateMouseOverreads the same field just as unguarded, and the NREs still occur.We can safely skip the method (returning
false) until there is a camera manager. Nothing can be moused over before then, and stock threw straight back out of the method at that point anyway. This change maintains the existing behaviour, without the NREs polluting the game log.