Skip to content

KC-1260: Support combined folder search with multiple -c flags#2084

Merged
sshrushanth-ks merged 3 commits into
keeper-drive-commands-fixfrom
keeper-drive-commands-fix-int
May 28, 2026
Merged

KC-1260: Support combined folder search with multiple -c flags#2084
sshrushanth-ks merged 3 commits into
keeper-drive-commands-fixfrom
keeper-drive-commands-fix-int

Conversation

@sshrushanth-ks
Copy link
Copy Markdown
Contributor

Summary

The search command now accepts multiple -c flags so a single query can return both Classic shared folders and KeeperDrive folders together in one JSON response. Previously, passing -c s -c d would silently drop the first flag and only search the last category.

Changes

  • Changed -c from action='store' to action='append' so repeated flags accumulate into a list instead of overwriting each other
  • Updated category parsing to join the list of values into a single string before the existing letter-membership checks run
  • Updated the JSON details field for Classic shared folders to Folder Category: Classic
  • Updated the JSON details field for KeeperDrive folders to Folder Category: KeeperDrive
  • Updated the help text to document that -c is repeatable and show the -c s -c d example

search -c s -c d now returns Classic shared folders and KeeperDrive
folders together in one JSON response. Changed -c from action='store'
to action='append' so repeated flags accumulate instead of overwriting.
JSON details field now shows Folder Category: Classic or
Folder Category: KeeperDrive for folder results.
@sshrushanth-ks sshrushanth-ks self-assigned this May 26, 2026
@sshrushanth-ks sshrushanth-ks marked this pull request as ready for review May 26, 2026 11:41
NSF folders with no parent UID previously rendered an empty details
field. Now always shows Folder Category: NestedShare, with Parent UID
appended when the folder is not at root level.
Comment thread keepercommander/commands/record.py Outdated
'"s" = shared folders, "t" = teams, "d" = Nested Share Folders')
search_parser.add_argument('-c', '--categories', dest='categories', action='append',
help='Category to search — repeatable: "r" = records, "s" = Classic shared folders, '
'"t" = teams, "d" = KeeperDrive folders. '
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update this to "s" = shared folders, "d" = Nested Share Folders')

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@sshrushanth-ks sshrushanth-ks merged commit 09fdb06 into keeper-drive-commands-fix May 28, 2026
4 checks passed
sshrushanth-ks added a commit that referenced this pull request May 28, 2026
* Support combined folder search with multiple -c flags

search -c s -c d now returns Classic shared folders and KeeperDrive
folders together in one JSON response. Changed -c from action='store'
to action='append' so repeated flags accumulate instead of overwriting.
JSON details field now shows Folder Category: Classic or
Folder Category: KeeperDrive for folder results.

* Fix nested_share_folder details always shown in JSON search output

NSF folders with no parent UID previously rendered an empty details
field. Now always shows Folder Category: NestedShare, with Parent UID
appended when the folder is not at root level.

* Fix help text for -c flag to use Nested Share Folders instead of KeeperDrive
craiglurey pushed a commit that referenced this pull request May 28, 2026
#2096)

* Support combined folder search with multiple -c flags

search -c s -c d now returns Classic shared folders and KeeperDrive
folders together in one JSON response. Changed -c from action='store'
to action='append' so repeated flags accumulate instead of overwriting.
JSON details field now shows Folder Category: Classic or
Folder Category: KeeperDrive for folder results.

* Fix nested_share_folder details always shown in JSON search output

NSF folders with no parent UID previously rendered an empty details
field. Now always shows Folder Category: NestedShare, with Parent UID
appended when the folder is not at root level.

* Fix help text for -c flag to use Nested Share Folders instead of KeeperDrive
sk-keeper pushed a commit that referenced this pull request May 29, 2026
#2096)

* Support combined folder search with multiple -c flags

search -c s -c d now returns Classic shared folders and KeeperDrive
folders together in one JSON response. Changed -c from action='store'
to action='append' so repeated flags accumulate instead of overwriting.
JSON details field now shows Folder Category: Classic or
Folder Category: KeeperDrive for folder results.

* Fix nested_share_folder details always shown in JSON search output

NSF folders with no parent UID previously rendered an empty details
field. Now always shows Folder Category: NestedShare, with Parent UID
appended when the folder is not at root level.

* Fix help text for -c flag to use Nested Share Folders instead of KeeperDrive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants