KC-1260: Support combined folder search with multiple -c flags#2084
Merged
sshrushanth-ks merged 3 commits intoMay 28, 2026
Merged
Conversation
search -c s -c d now returns Classic shared folders and KeeperDrive folders together in one JSON response. Changed -c from action='store' to action='append' so repeated flags accumulate instead of overwriting. JSON details field now shows Folder Category: Classic or Folder Category: KeeperDrive for folder results.
sali-ks
approved these changes
May 26, 2026
NSF folders with no parent UID previously rendered an empty details field. Now always shows Folder Category: NestedShare, with Parent UID appended when the folder is not at root level.
pvagare-ks
reviewed
May 28, 2026
| '"s" = shared folders, "t" = teams, "d" = Nested Share Folders') | ||
| search_parser.add_argument('-c', '--categories', dest='categories', action='append', | ||
| help='Category to search — repeatable: "r" = records, "s" = Classic shared folders, ' | ||
| '"t" = teams, "d" = KeeperDrive folders. ' |
Contributor
There was a problem hiding this comment.
update this to "s" = shared folders, "d" = Nested Share Folders')
sshrushanth-ks
added a commit
that referenced
this pull request
May 28, 2026
* Support combined folder search with multiple -c flags search -c s -c d now returns Classic shared folders and KeeperDrive folders together in one JSON response. Changed -c from action='store' to action='append' so repeated flags accumulate instead of overwriting. JSON details field now shows Folder Category: Classic or Folder Category: KeeperDrive for folder results. * Fix nested_share_folder details always shown in JSON search output NSF folders with no parent UID previously rendered an empty details field. Now always shows Folder Category: NestedShare, with Parent UID appended when the folder is not at root level. * Fix help text for -c flag to use Nested Share Folders instead of KeeperDrive
craiglurey
pushed a commit
that referenced
this pull request
May 28, 2026
#2096) * Support combined folder search with multiple -c flags search -c s -c d now returns Classic shared folders and KeeperDrive folders together in one JSON response. Changed -c from action='store' to action='append' so repeated flags accumulate instead of overwriting. JSON details field now shows Folder Category: Classic or Folder Category: KeeperDrive for folder results. * Fix nested_share_folder details always shown in JSON search output NSF folders with no parent UID previously rendered an empty details field. Now always shows Folder Category: NestedShare, with Parent UID appended when the folder is not at root level. * Fix help text for -c flag to use Nested Share Folders instead of KeeperDrive
sk-keeper
pushed a commit
that referenced
this pull request
May 29, 2026
#2096) * Support combined folder search with multiple -c flags search -c s -c d now returns Classic shared folders and KeeperDrive folders together in one JSON response. Changed -c from action='store' to action='append' so repeated flags accumulate instead of overwriting. JSON details field now shows Folder Category: Classic or Folder Category: KeeperDrive for folder results. * Fix nested_share_folder details always shown in JSON search output NSF folders with no parent UID previously rendered an empty details field. Now always shows Folder Category: NestedShare, with Parent UID appended when the folder is not at root level. * Fix help text for -c flag to use Nested Share Folders instead of KeeperDrive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The search command now accepts multiple -c flags so a single query can return both Classic shared folders and KeeperDrive folders together in one JSON response. Previously, passing -c s -c d would silently drop the first flag and only search the last category.
Changes