KC-1267: Fix: consistent folder JSON response across get, ls, and nsf-get commands#2092
Open
sshrushanth-ks wants to merge 1 commit into
Open
KC-1267: Fix: consistent folder JSON response across get, ls, and nsf-get commands#2092sshrushanth-ks wants to merge 1 commit into
sshrushanth-ks wants to merge 1 commit into
Conversation
sgaddala-ks
reviewed
May 30, 2026
| is_nested_share = hasattr(params, 'nested_share_folders') and f.uid in params.nested_share_folders | ||
| source = 'Nested Share Folder' if is_nested_share else 'Legacy' | ||
| row = ['folder', f.uid, f.name, f'Flags: {folder_flags(f)}, Parent: {f.parent_uid or "/"}', source] | ||
| folder_type = 'nested_share_folder' if is_nested_share else f.type |
There was a problem hiding this comment.
comparing with raw strings is not a good idea
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Folder JSON responses were inconsistent across get, ls, and nsf-get commands — using different field names for the same data, missing parent_uid, and inconsistent type/source values. This fix standardises the response format across all three commands and adds --include-dag support to nsf-get.
Changes