Fix: Stop silently inheriting SSL_CERT_FILE from process env#2094
Merged
amangalampalli-ks merged 2 commits intoMay 29, 2026
Merged
Conversation
sgaddala-ks
reviewed
May 29, 2026
…hon package name The hyphen in os-keychain caused find_packages() to skip the directory, so it was not included in the PyPI wheel. PyInstaller also failed to bundle it correctly. Renaming to os_keychain (underscore) fixes both. loader.py normalises the URI scheme (os-keychain -> os_keychain) before resolving the plugin module, so config.json entries are unchanged. Co-authored-by: Cursor <cursoragent@cursor.com>
pvagare-ks
approved these changes
May 29, 2026
amangalampalli-ks
merged commit 8f8162e
into
fix/ssl-cert-file-inheritance
4 checks passed
amangalampalli-ks
added a commit
that referenced
this pull request
May 29, 2026
* fix: honor bundled certifi store on Windows * fix: rename os-keychain plugin directory to os_keychain for valid Python package name The hyphen in os-keychain caused find_packages() to skip the directory, so it was not included in the PyPI wheel. PyInstaller also failed to bundle it correctly. Renaming to os_keychain (underscore) fixes both. loader.py normalises the URI scheme (os-keychain -> os_keychain) before resolving the plugin module, so config.json entries are unchanged. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: sshrushanth-ks <sshrushanth@keepersecurity.com> Co-authored-by: Cursor <cursoragent@cursor.com>
sk-keeper
pushed a commit
that referenced
this pull request
May 29, 2026
* fix: honor bundled certifi store on Windows * fix: rename os-keychain plugin directory to os_keychain for valid Python package name The hyphen in os-keychain caused find_packages() to skip the directory, so it was not included in the PyPI wheel. PyInstaller also failed to bundle it correctly. Renaming to os_keychain (underscore) fixes both. loader.py normalises the URI scheme (os-keychain -> os_keychain) before resolving the plugin module, so config.json entries are unchanged. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: sshrushanth-ks <sshrushanth@keepersecurity.com> Co-authored-by: Cursor <cursoragent@cursor.com>
sk-keeper
pushed a commit
that referenced
this pull request
May 29, 2026
* fix: honor bundled certifi store on Windows * fix: rename os-keychain plugin directory to os_keychain for valid Python package name The hyphen in os-keychain caused find_packages() to skip the directory, so it was not included in the PyPI wheel. PyInstaller also failed to bundle it correctly. Renaming to os_keychain (underscore) fixes both. loader.py normalises the URI scheme (os-keychain -> os_keychain) before resolving the plugin module, so config.json entries are unchanged. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: sshrushanth-ks <sshrushanth@keepersecurity.com> Co-authored-by: Cursor <cursoragent@cursor.com>
jpkeepersecurity
pushed a commit
that referenced
this pull request
Jun 1, 2026
* fix: honor bundled certifi store on Windows * fix: rename os-keychain plugin directory to os_keychain for valid Python package name The hyphen in os-keychain caused find_packages() to skip the directory, so it was not included in the PyPI wheel. PyInstaller also failed to bundle it correctly. Renaming to os_keychain (underscore) fixes both. loader.py normalises the URI scheme (os-keychain -> os_keychain) before resolving the plugin module, so config.json entries are unchanged. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: sshrushanth-ks <sshrushanth@keepersecurity.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #2069
On Windows, Commander silently honored
SSL_CERT_FILEif set in the environment by unrelated tools (Zscaler, Anaconda, IT scripts), redirecting trust away from the bundled_internal\certifi\cacert.pem. This broke the workflow for customers behind TLS-inspecting proxies.Fix
ssl.get_default_verify_paths()block inget_ssl_cert_file()so Commander no longer inherits trust decisions from the surrounding env.KEEPER_SSL_CERT_FILE(certifi|system|none/false|<path>) remains the supported explicit override.get_ssl_cert_file()(existed in both__main__.pyandutils.py) into a single implementation inutils.py.Testing (Windows)
Using SSL certificate file:SSL_CERT_FILEpoisoned (bug repro)KEEPER_SSL_CERT_FILE=<path>keeper loginon clean env