Secrets Manager app rename and share permission update#171
Open
mtyagi-ks wants to merge 3 commits into
Open
Conversation
Align keeper-cli KSM with Commander by supporting application rename via vault/records_update and toggling record/shared-folder editable vs read-only on existing app shares (remove + re-add). - SDK: update_secrets_manager_app, update_secrets_manager_app_shares - CLI: secrets-manager-app update --name; secrets-manager-share update
sgaddala-ks
approved these changes
May 26, 2026
|
LGTM. Only issue I have is that string comparison using direct strings instead of a constant. using constants/ enum will make it easier to change later if needed. |
sali-ks
reviewed
May 26, 2026
| if response is None: | ||
| raise KeeperApiError('unknown', 'vault/records_update returned no response') | ||
|
|
||
| status = next((x for x in response.records if record_uid_bytes == x.record_uid), None) |
There was a problem hiding this comment.
validate the status
if not status:
raise KeeperApiError('unknown', f'No status returned for record {app_uid}')
sali-ks
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align keeper-cli KSM with Commander by supporting application rename via vault/records_update and toggling record/shared-folder editable vs read-only on existing app shares (remove + re-add).