Fix password-report vault-wide scan when folder argument is omitted#173
Open
mtyagi-ks wants to merge 2 commits into
Open
Fix password-report vault-wide scan when folder argument is omitted#173mtyagi-ks wants to merge 2 commits into
mtyagi-ks wants to merge 2 commits into
Conversation
sgaddala-ks
approved these changes
May 26, 2026
sali-ks
reviewed
May 26, 2026
|
|
||
| def add_records(folder: vault_types.Folder) -> None: | ||
| record_uids.update(folder.records) | ||
|
|
There was a problem hiding this comment.
avoids repeating the function call. like
folder = context.vault.vault_data.root_folder
if folder_uid:
folder = context.vault.vault_data.get_folder(folder_uid)
if not folder:
raise base.CommandError(f'Folder {folder_uid} not found')
vault_utils.traverse_folder_tree(
context.vault.vault_data,
folder,
add_records
)
sali-ks
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix password-report crash when no folder is specified
get_folder('') returns None, so accessing folder.records raised
AttributeError. Scan the whole vault from root_folder via
traverse_folder_tree when no folder argument is given, matching
Commander behavior.