Skip to content

Stop publishing the .vscode folder - #103

Merged
somewhatabstract merged 1 commit into
mainfrom
ignorevscode
Nov 11, 2026
Merged

somewhatabstract merged 1 commit into
mainfrom
ignorevscode

Conversation

@somewhatabstract

Copy link
Copy Markdown
Member

Summary:

The published package includes .vscode/settings.json. The macOS sandbox
that coding agents run in denies writes to .vscode anywhere under the
working directory, so a sandboxed pnpm install fails on any project that
depends on this package. Khan/frontend vendors a repacked copy of 4.0.1
until a release without it is out.

Issue: FEI-8793

Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_017Rd4bUBQBDtzvj2wiHWZVk

Test plan:

The published package includes .vscode/settings.json. The macOS sandbox
that coding agents run in denies writes to .vscode anywhere under the
working directory, so a sandboxed pnpm install fails on any project that
depends on this package. Khan/frontend vendors a repacked copy of 4.0.1
until a release without it is out.

Issue: FEI-8793

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017Rd4bUBQBDtzvj2wiHWZVk
@changeset-bot

changeset-bot Bot commented Nov 10, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 057b2d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@khanacademy/graphql-flow Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kevinb-khan kevinb-khan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@somewhatabstract
somewhatabstract merged commit 5710ad3 into main Nov 11, 2026
1 check passed
@somewhatabstract
somewhatabstract deleted the ignorevscode branch November 11, 2026 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants