Skip to content

Move CI and releases to Node 24 - #104

Merged
somewhatabstract merged 1 commit into
mainfrom
fixrelease
Nov 12, 2026
Merged

somewhatabstract merged 1 commit into
mainfrom
fixrelease

Conversation

@somewhatabstract

Copy link
Copy Markdown
Member

Summary:

The release job ran on Node 20 and then installed npm@latest to get the
npm 11.5.1+ that trusted publishing needs. npm@latest is now npm 12,
which requires Node ^22.22.2, ^24.15.0 or >=26, so the install failed
with EBADENGINE.

Node 24 bundles npm 11.19, so run the release job on 24.x and check the
bundled npm is new enough instead of upgrading it. That keeps a future
npm major from breaking the release the same way. The PR checks move to
24.x too, so tests run on the Node that publishes.

Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_017Rd4bUBQBDtzvj2wiHWZVk

Issue: FEI-8793

Test plan:

The release job ran on Node 20 and then installed npm@latest to get the
npm 11.5.1+ that trusted publishing needs. npm@latest is now npm 12,
which requires Node ^22.22.2, ^24.15.0 or >=26, so the install failed
with EBADENGINE.

Node 24 bundles npm 11.19, so run the release job on 24.x and check the
bundled npm is new enough instead of upgrading it. That keeps a future
npm major from breaking the release the same way. The PR checks move to
24.x too, so tests run on the Node that publishes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017Rd4bUBQBDtzvj2wiHWZVk
@changeset-bot

changeset-bot Bot commented Nov 11, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: cc5691c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kevinb-khan kevinb-khan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I updated them all, but I guess I missed this one. Thanks for updating the config to use Node 24. It should probably specify 24.22.1 or higher until we've confirmed that the version of node installed when you select 24.x is 24.22.1 or higher. The last time I checked, GitHub was still installing a lower version for some reason.

@somewhatabstract

Copy link
Copy Markdown
Member Author

I thought I updated them all, but I guess I missed this one. Thanks for updating the config to use Node 24. It should probably specify 24.22.1 or higher until we've confirmed that the version of node installed when you select 24.x is 24.22.1 or higher. The last time I checked, GitHub was still installing a lower version for some reason.

I checked the logs. It's using 24.22.2.

@somewhatabstract
somewhatabstract merged commit f521846 into main Nov 12, 2026
1 check passed
@somewhatabstract
somewhatabstract deleted the fixrelease branch November 12, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants