Remove redundant len="1" attribute - #2785
Merged
Merged
Conversation
vkGetDeviceSubpassShadingMaxWorkgroupSizeHUAWEI::pMaxWorkgroupSize used `len="1"` attribute and was the only place where you could encounter such value. 1 is allowed value but itself is redundant and as mentioned in `registery.adoc` should be used for nested pointers like `len="<outer_len>,1` for array of pointers to single values
Contributor
|
Agreed. This does not result in any changes to generated files aside from not pluralizing VUID-vkGetDeviceSubpassShadingMaxWorkgroupSizeHUAWEI-pMaxWorkgroupSize-parameter, and is consistent with the text describing the parameter, so accepting as editorial. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vkGetDeviceSubpassShadingMaxWorkgroupSizeHUAWEI::pMaxWorkgroupSize used
len="1"attribute and was the only place where you could encounter such value. 1 is allowed value but itself is redundant and as mentioned inregistery.adocshould be used for nested pointers likelen="<outer_len>,1for array of pointers to single valuesI would ping HUAWEI. But I don't know how 😅