Misc and small python improvements - #2791
Open
holtowd wants to merge 1 commit into
Open
Conversation
gpx1000
reviewed
Aug 15, 2026
Contributor
|
This seems OK to me. I'd want to run some simple generated file comparisons but it's all very straightforward cleanup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tbh, I am not even sure it deserves any kind of review so feel to close right away without hesitation.
For me it sped up parsing of the registry
from vulkan_object import get_vulkan_object;vk = get_vulkan_object()from~840ms to ~810ms. Probably the least concerning thing of scripts of the codebase... I am stupid, I can't do more (at least for now) and just throwing away is kinda awkward for me so just close it if you want