build: Update required CMake version to 3.28.3 - #1975
Conversation
|
CI Vulkan-Loader build queued with queue ID 41691. |
|
CI Vulkan-Loader build queued with queue ID 41708. |
|
CI Vulkan-Loader build queued with queue ID 41757. |
|
CI failure is due to older CMake version. Will have to audit and update CI machines before this can be merged.
|
|
CI Vulkan-Loader build # 3640 running. |
|
CI Vulkan-Loader build # 3640 failed. |
There was a problem hiding this comment.
Highly recommend adding this as the standard way for package managers to disable warnings as errors while keeping life simple for devs
# https://cmake.org/cmake/help/latest/variable/CMAKE_COMPILE_WARNING_AS_ERROR.html
# Override at the command line with --compile-no-warning-as-error
set(CMAKE_COMPILE_WARNING_AS_ERROR ON)
8b66ef3 to
ac52c4f
Compare
|
CI Vulkan-Loader build queued with queue ID 68813. |
|
CI Vulkan-Loader build # 3684 running. |
|
CI Vulkan-Loader build queued with queue ID 68831. |
Also removed workarounds for older CMake versions.
Updates github actions to use Ubuntu 26.
ac52c4f to
d33fbcf
Compare
|
CI Vulkan-Loader build queued with queue ID 68832. |
|
CI Vulkan-Loader build # 3686 running. |
|
CI Vulkan-Loader build # 3686 failed. |
|
Errors are expected as the CI machine(s) are not all updated to 3.28 yet. |
CMake now offers a mechanism to enable compiler warnings as errors with ease. BUILD_WERROR is now implemented in terms of this new mechanism.
|
CI Vulkan-Loader build queued with queue ID 69055. |
|
CI Vulkan-Loader build queued with queue ID 69072. |
3 participants
Also removed workarounds for older CMake versions.
FYI @JP42Edit: Pinged the wrong person, apologies