Skip to content

Fix flat interpolation check on fs inputs qualified with perPrimitiveNV - #4050

Open
dreamelon wants to merge 1 commit into
KhronosGroup:mainfrom
dreamelon:main
Open

dreamelon wants to merge 1 commit into
KhronosGroup:mainfrom
dreamelon:main

Conversation

@dreamelon

Copy link
Copy Markdown

Spec allows any interpolation qualifier on fragment shader inputs qualified with "perprimitiveNV".
https://github.com/KhronosGroup/GLSL/blob/d368fe808d7e11476945901120510edbe490f961/extensions/nv/GLSL_NV_mesh_shader.txt#L1119

@dreamelon

Copy link
Copy Markdown
Author

Ping for review

@dnovillo dnovillo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix itself LGTM, but this needs a test. Please add a test that exercises this path. Maybe something like

#version 450
#extension GL_NV_mesh_shader : require
layout(location = 0) perprimitiveNV in int idx;
layout(location = 0) out vec4 fragColor;
void main() { fragColor = vec4(float(idx)); }

@dnovillo

Copy link
Copy Markdown
Collaborator

@dreamelon are you still working on this PR?

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants