RoF #325
Open
RoF #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skip ci]
ArturT
approved these changes
Jan 22, 2026
| end | ||
|
|
||
| if test_files.empty? | ||
| KnapsackPro.logger.warn("No test files were executed on this CI node.") |
Member
There was a problem hiding this comment.
question
No message at all? I recall people saying that some nodes are not running tests. They assumed this was a bug. This message is intended to clarify that this is expected behaviour.
| KNAPSACK_PRO_PROJECT_DIR=. \ | ||
| KNAPSACK_PRO_CI_NODE_TOTAL=${2:-2} \ | ||
| KNAPSACK_PRO_CI_NODE_INDEX=${1:-0} \ | ||
| KNAPSACK_PRO_TEST_QUEUE_ID=${3:-$CI_BUILD_ID} \ |
Member
There was a problem hiding this comment.
question
Is this needed in the regular mode? I think it's not. You could remove it then.
|
|
||
| it 'logs a warning' do | ||
| expect(described_class).to receive(:warn).with( | ||
| 'You have set the environment variable KNAPSACK_PRO_TEST_QUEUE_ID to env:456 which could be automatically determined from the CI environment as abc:123.' |
Member
There was a problem hiding this comment.
suggestion
This message could be more actionable. Tell the user to remove KNAPSACK_PRO_TEST_QUEUE_ID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See https://github.com/KnapsackPro/knapsack-pro-api/pull/1433
Checks
UNRELEASEDsection of theCHANGELOG.md, including the needed bump (i.e., patch, minor, major)lib/knapsack_pro/pure/queue/rspec_pure.rbcontains pure functions that are unit tested.lib/knapsack_pro/extensions/rspec_extension.rbencapsulates calls to RSpec internals and is integration and E2E tested.lib/knapsack_pro/runners/queue/rspec_runner.rbinvokes the pure code and the extension to produce side effects, which are integration and E2E tested.