refactor(lua): extract lua_callback_factory for register_* activation closures - #400
Merged
Merged
Conversation
… closures register_palette_command / register_keybind built the same fetch-from-registry + call + warn-on-error closure inline. One helper, both sites delegate; the Rc around RegistryKey goes away since the factory is now the key's sole owner. Closes #314
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
This refactoring successfully extracts duplicated activation closure logic into a shared lua_callback_factory function. The changes eliminate ~40 lines of duplicate code while maintaining the same functionality. The removal of the Rc<RegistryKey> wrapper is safe since mlua's RegistryKey Drop implementation handles automatic cleanup when the closure is dropped. No blocking issues identified.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #314.
Both
register_palette_commandandregister_keybindbuilt the same activation closure inline: fetch the callback from the Lua registry, call it,log::warn!+ swallow on error. Extractedlua_callback_factory(lua, key, tag) -> SpawnComponent; theRc<RegistryKey>wrapper is gone since the factory closure is now the key's sole owner.🤖 Generated with Claude Code
https://claude.ai/code/session_019Ktx7C4Zf26MhQABaPNYze