Feature/match cad scale - #13
Open
Ludofr3 wants to merge 9 commits into
Open
Conversation
…d on the CAD model's bounding box size
…ometry/bot into feature/match-cad-scale
Ludofr3
marked this pull request as draft
July 24, 2026 08:29
Normalizes loaded CAD models to a uniform scale and handles world-to-local coordinate conversions for Gmsh operations. Adjusts camera frustums and raycasting distances accordingly. - Calculates model scale factor based on bounding box dimensions - Dynamically configures Gmsh mesh sizing relative to model size - Converts coordinates for point creation, queries, and node meshes - Removes redundant spline scaling logic from `SplineModel` - Refines camera near/far clipping planes and extends raycast limits
Ludofr3
marked this pull request as ready for review
July 24, 2026 09:38
Extracts shared adapter state into BaseAdapter and parameterizes curve and hover color definitions across viewer components. - Extracts `BaseAdapter` for `CADAdapter` and `SplineAdapter` - Replaces hardcoded RGBA values with color attributes in adapters - Sets cyan line color rendering for spline curves in `CurveApp` - Updates default curve highlight color in viewer
Extracts duplicated hover and selection handling from CADAdapter and SplineAdapter into BaseAdapter. Converts private adapter methods to protected methods across the module. - Moves `_handle_hover` and `_handle_curve_selected` to `BaseAdapter` - Adds `_get_hover_info` hook for model-specific HUD info formatting - Updates type hints and improves pick event handling in `CADAdapter`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.