Refactor Channel on top of sunkit_instruments.response.abstractions.AbstractChannel#344
Draft
wtbarnes wants to merge 7 commits into
Draft
Refactor Channel on top of sunkit_instruments.response.abstractions.AbstractChannel#344wtbarnes wants to merge 7 commits into
Channel on top of sunkit_instruments.response.abstractions.AbstractChannel#344wtbarnes wants to merge 7 commits into
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
10 tasks
0d5ba02 to
9161613
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first attempt at refactoring the
Channelclass on top of theAbstractChannelclass fromsunkit-instruments. The latter is still in the form of a draft PR sunpy/sunkit-instruments#98 so this is an experimental PR at this stage.The goal here is to easily enable calculating the temperature response functions.
As it stands, this represents a breaking change to the
ChannelAPI.ToDos before this can be merged:
sunkit-instrumentsrelease includingAbstractChannelSummary by Sourcery
Refactor the
Channelclass to extendAbstractChannel, enhancing the API with additional parameters and methods for more flexible and accurate temperature response function calculations. This change introduces a breaking change to theChannelAPI.Enhancements:
Channelclass to inherit fromAbstractChannel, introducing a more structured approach to handling channel properties and response functions.Channelclass constructor, includinginclude_eve_correction,include_crosstalk,correction_table, andcalibration_version, to enhance flexibility in response function calculations.primary_reflectancetoprimary_mirror_reflectanceandfocal_plane_filter_efficiencytofocal_plane_filter_transmittance.mirror_reflectance,filter_transmittance, andenergy_per_electron.