Skip to content

Spec0 action run on v1.4#408

Open
nabobalis wants to merge 2 commits into
mainfrom
spec0
Open

Spec0 action run on v1.4#408
nabobalis wants to merge 2 commits into
mainfrom
spec0

Conversation

@nabobalis

@nabobalis nabobalis commented Jun 12, 2026

Copy link
Copy Markdown
Member

Summary by Sourcery

Update dependency versions and CI workflow to align with newer tooling releases.

Enhancements:

  • Relax and bump minimum versions for performance, testing, and documentation optional dependencies to more recent releases.

CI:

  • Update the SPEC0 GitHub Action workflow to use the v1.4 action commit.

@nabobalis nabobalis added the No Changelog Entry Needed Skip all changelog checks. label Jun 12, 2026
@sourcery-ai

sourcery-ai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Update development tooling and optional dependency versions to align with spec0-action v1.4 while tightening minimum versions for performance, testing, and documentation extras.

File-Level Changes

Change Details Files
Tighten and modernize optional dependency version constraints for performance, testing, and documentation extras.
  • Set minimum version for JAX in performance extras, including CUDA and macOS metal variants.
  • Raise pytest-related packages to explicit, recent minimum versions in the tests extra.
  • Pin Sphinx and related documentation tooling to explicit, recent minimum versions, including sphinx theme and extensions.
pyproject.toml
Upgrade the GitHub Actions workflow to use scientific-python/spec0-action v1.4.
  • Update the pinned commit SHA of scientific-python/spec0-action to the v1.4 commit.
  • Keep existing update_all configuration, continuing to bump non-SPEC0 dependencies older than 2 years.
.github/workflows/update-spec0.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • In the docs extra, sunpy-sphinx-theme is listed twice with the same version constraint; consider removing the duplicate entry to keep the dependency list clean and avoid confusion.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In the `docs` extra, `sunpy-sphinx-theme` is listed twice with the same version constraint; consider removing the duplicate entry to keep the dependency list clean and avoid confusion.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread pyproject.toml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No Changelog Entry Needed Skip all changelog checks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant