Raise the CI database statement timeout to 10 minutes - #7184
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Author
|
Note on the close/reopen in the timeline: the first CI run hit a transient |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Raise the default PostgreSQL statement timeout used by the test tox environment
from 120 seconds to 10 minutes.
Motivation
The two-minute timeout introduced in #7181 successfully prevents unbounded
queries, but it also acts as a sharp performance threshold against the shared
devmirror database. The completeness test has now crossed that threshold in
multiple runs even though the underlying logical result is correct (e.g.
https://github.com/LMFDB/lmfdb/actions/runs/31268853079/job/93204410081, which
canceled the null-data probe for an intrinsically impossible
nf_fieldsquery while it was waiting on the timeout).
Ten minutes still catches a pathological statement far earlier than the
60-minute GitHub Actions job timeout while leaving substantially more headroom
for transient load.
Scope
This PR intentionally changes only
tox.ini. The expensive completeness queryand CI matrix concurrency are addressed separately.
Verification
tox config -e testsresolves the default tostatement_timeout=10min.PGOPTIONSvalue still overrides the default (checked withPGOPTIONS='-c statement_timeout=0' tox config -e tests).git diff --checkpasses.🤖 Generated with Claude Code