Repository navigation
fix(touch): keep moves that only work together, such as swapping the stick and A B X Y - #1259
Open
528z4b2kgc-ux wants to merge 1 commit into
Open
528z4b2kgc-ux wants to merge 1 commit into
528z4b2kgc-ux wants to merge 1 commit into
Conversation
528z4b2kgc-ux
force-pushed
the
fix/touch-arrange-together
branch
from
November 14, 2026 17:17
e085d30 to
34db9ca
Compare
…stick and A B X Y Moved touch controls were placed one at a time, so a swap left both controls at their built-in places. The engine patch (0055) and the editor's TouchPadGeometry.swift now try every moved control together first, then fall back to one at a time. Tests: check_swap and theStickAndTheDiamondTradePlaces. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
528z4b2kgc-ux
force-pushed
the
fix/touch-arrange-together
branch
from
November 15, 2026 00:03
34db9ca to
2b70f2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix or feature
What and why
Problem. Swapping two touch controls, such as the left stick and A B X Y, is rejected, and both go back to their built-in places.
Cause. Moved controls are placed one at a time, so each waits for a place the other still holds.
Change. Placement tries all moved controls together first, then falls back to one at a time. The engine patch and the editor's
TouchPadGeometry.swiftchange the same way.Checked
TouchLayoutTestspasses;pad_geometry_check.mpasses (14 screens, 10080 arrangements);python3 tools/engine.py checkpasses.check_swap(engine) andtheStickAndTheDiamondTradePlaces(editor). Both fail without the fix.Screenshots
None, no visible change.
Scope
dm/,scripts/,docs/,ref/) is added to the repository: a change there is a patch inpatches/(a commit inengine/, thentools/engine.py export, andtools/engine.py checkpasses), with itsUpstream-Statusforwarded seedds/nxnative#..., orpendinguntil that PR is openDetails
0020-ios-touch-controls-layout, which is not in seedds/nxnative yet (it builds on iOS: adapt gameplay to Duo portrait and tabletop poses seedds/nxnative#683). So there is no upstream file to send this to; the patch sayspendingwith that note.🤖 Generated with Claude Code