[TomiMalamud]

Follow-up to #117, from three review passes over @facturas/pdf. I reproduced each finding in a rendered PDF before fixing it. Each has a test that fails without its fix.

Fixes

1. Long notes broke the layout. The closing block (totals, legends, notes, fiscal footer) could not split. With long notes, the totals overlapped the lines and the notes ran over the CAE and off the page.
   • Notes moved: they now sit after the receiver and before the lines, like Stripe's memo, and break across sheets freely.
   • Closing block: it no longer holds free text. The total, legends and fiscal footer still move together, so the CAE is never alone on a sheet.
   • Tried first: minPresenceAhead and an absolutely positioned footer. Neither held the footer to the last content sheet.
2. Tokens wider than the description column overran the price columns. A token longer than 20 characters, such as a URL, may now break anywhere. Words still wrap whole.
3. Rows taller than a sheet were clipped. Every row was unbreakable. A row whose description is over 600 characters may now continue on the next sheet.
4. Long tax names ran into their amount. "Percepción de Ingresos Brutos Provincia de Buenos Aires" is wider than the totals column. The label now wraps in its own column, and the amount keeps its width.
5. A long tax breakdown outgrew the sheet. With 15 wrapped tax rows, react-pdf squeezed the closing block's lines to about 3.3 pt apart (review comment).
   • Usual breakdown: it stays in one block with the total and the CAE, with <VoucherAside> beside it.
   • Long breakdown: when its estimated height passes 250 pt, its rows flow and may continue on the next sheet. Only "Importe total" stays with the legends and the fiscal footer.

Visible change

<VoucherNotes> and the notes option now print before the lines instead of after the totals. The guide, the changeset and the doc comments say so. <VoucherAside> moves with the totals and the CAE, so the guide asks to keep it short.

Tests

• Sheet edge: one test sweeps 20 to 32 lines across the first sheet's edge and checks that the totals always share the CAE's sheet.
• One per finding: long notes (70 clauses, all printed, above the totals), an oversized token, an oversized row, a long tax name, and 15 long tax rows (line spacing kept on every sheet, total with the CAE).

Validation

• pnpm check
• pnpm typecheck
• pnpm test
• pnpm typecheck:examples
• pnpm check:docs
• pnpm --filter @facturas/pdf build

🤖 Generated with Claude Code

https://claude.ai/code/session_01PWf3KVPSbVbfiQgseVoyNW

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

[TomiMalamud]

One reproduced PDF pagination regression; details inline.

[TomiMalamud]

Encontré una regresión de paginación en 32fb004: el aside de pagos y saldo se separa del importe total cuando el desglose de impuestos se pagina. Reproducción y propuesta en el comentario inline.