Repository navigation
Centre the voucher letter whatever the bold font - #122
Merged
Merged
Conversation
The letter had lineHeight 1, which sinks the capital by the font's ascent: 1 pt with Helvetica and 3.6 pt with Geist. Without it, the font's own line box centres the capital: within 0.25 pt for Helvetica, Times and Geist. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PWf3KVPSbVbfiQgseVoyNW
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With lapyme's Geist theme, the letter sat low in its box. The cause is the letter's
lineHeight: 1: react-pdf places the baseline at the font's ascent within that fixed line box, so a font with a tall ascent sinks the capital.Measured
Baseline of a 24 pt capital in the 40 pt box, compared with the baseline that centres the capital, in points:
lineHeight: 1)Change
theme.ts: the letter style dropslineHeight, and a comment says why. The box keeps its fixed 40 × 40 size, so nothing else in the header moves.lineHeight: 1the test fails with 0.98 pt.Validation
pnpm checkpnpm typecheckpnpm testpnpm check:docs🤖 Generated with Claude Code
https://claude.ai/code/session_01PWf3KVPSbVbfiQgseVoyNW
Generated by Claude Code