Agents updated for Vitest v4#165
Conversation
📝 WalkthroughWalkthroughThis PR updates tooling infrastructure: adds GitHub issue viewing permission for Claude, bumps multiple frontend and dependency versions (including Nuxt, Vue tooling, and KiotaBundle), and corrects a test command example by removing an unnecessary separator. ChangesMaintenance and tooling updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@template/copier_template_resources/`{% if template_uses_typescript
%}vitest-run.mjs{% endif %}:
- Line 31: The current noCoverage handling only removes the exact token
"--coverage" from fixed (see variables fixedFiltered, noCoverage, fixed), so
coverage variants like "--coverage=true" or "--coverage.enabled" remain; update
the logic that builds fixedFiltered to either remove any argument that starts
with "--coverage" or matches coverage-enabled patterns (e.g., prefix
"--coverage" or "--coverage."), or alternatively append explicit overrides like
"--coverage=false" and "--coverage.enabled=false" when noCoverage is true so all
Vitest coverage variants are disabled.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 2aafa482-ba5f-402c-8026-241c2fc83fa9
📒 Files selected for processing (3)
.claude/settings/permissions/bash.jsoncextensions/context.pytemplate/copier_template_resources/{% if template_uses_typescript %}vitest-run.mjs{% endif %}
Use startsWith("--coverage") instead of exact equality so variants like
--coverage=true and --coverage.enabled are also stripped when --no-coverage is set.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
NIT we should update the PR description to match where we landed for the real fix. |
Why is this change necessary?
With Vitest v4 and the "projects" format, passing in positional arguments at the end of a pnpm script command didn't actually get passed to vitest. e.g.
pnpm test-unit -- tests/unit/blah.spec.tswould still run the whole test suite, not just that one fileHow does this change address the issue?
Updates Agents.md to tell it not to use the
--What side effects does this change have?
N/A
How is this change tested?
Downstream repos
Summary by CodeRabbit