Auto imports for frontend E2E tests#167
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR adds conditional support for Changesunplugin-auto-import support
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| @@ -1,8 +1,9 @@ | |||
| import { fileURLToPath } from "node:url"; | |||
There was a problem hiding this comment.
usually when we make something jinja, we begin with {% raw %} because there's so many footguns about jinja syntax
| "@": appDir, | ||
| }, | ||
| }, | ||
| {% if is_circuit_python_driver %} |
There was a problem hiding this comment.
NIT: maybe change this to a "include_lab_sync_nuxt_common_module" copier question? since several other non-circuit-python repos will want to use it too
There was a problem hiding this comment.
I concur but id like to defer this for the moment. Ill create an issue to track it
| }, | ||
| }, | ||
| }); | ||
| {% endraw %} |
There was a problem hiding this comment.
Put endraw at the end of line 130 and leave 131 blank
There was a problem hiding this comment.
take a look at some of the other jinja files to see the pattern
There was a problem hiding this comment.
are you sure? if i dont do this wont it still add an extra line and ts will fail b/c it doesn't want the extra endline? e5a4c4c
Link to Issue or Message thread
Part of work figuring out https://github.com/lab-sync/copier-circuit-python-device-driver-frontend/pull/3
Why is this change necessary?
The device e2e test are using useKiotaClient. This works in the context of a nuxt app but not when you are doing an e2e test that is using node. Similar to the comment we have around ~~, @@, ~, and @ aliases we need to do this config so that the auto import of the useKiotaClient will work in that context as well.
How does this change address the issue?
Adds unplugin-auto-import dep and config it for kiota in the context of the e2e tests only.
What side effects does this change have?
E2E tests are now able to run (get to the next error 🤣 )
How is this change tested?
Downstream in driver
Summary by CodeRabbit