let API pull in google dependencies#414
Closed
labkey-matthewb wants to merge 2 commits intodevelopfrom
Closed
Conversation
labkey-susanh
approved these changes
Jan 20, 2026
SequenceAnalysis/build.gradle
Outdated
| // google-genai dependencies in API pull in newer versions of these modules | ||
| exclude group: "com.google.api", module : "api-common" | ||
| exclude group: "com.google.auth", module : "google-auth-library-oauth2-http" | ||
| exclude group: "com.google.auth", module : "google-auth-library-credentials" |
There was a problem hiding this comment.
Since those are being pulled in from API, this is probably ok. Usually we go the route of forcing a particular version of dependencies when there's a conflict. It allows the dependency to come through to the module without relying on the presence of the other module (though, of course, for API it will always be there), but it also can result in duplicate (transitive) dependencies, so it's a bit of a tradeoff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
dependency resolution
Related Pull Requests
Changes