Rework CachedResultSetBuilder to require column types

[labkey-adam]

Rationales

The crawler recently induced a CachedResultSet was not closed exception caused by the ProtocolManagementWebPart. This can be reproduced by adding a "Pipeline Protocols" webpart to a portal page and then adding a bogus returnUrl parameter to the URL; for example: project-begin.view?returnUrl=">%27>%27"<script>alert(%278(%27)<%2Fscript>

Also, use of a CachedResultSetBuilder initialized with a list of column names would cause the logging of multiple Unknown SQL Type Name ""; using OTHER instead. messages.

Changes

• Reorder the ProtocolManagementWebPart constructor so it creates and stashes its CachedResultSet at the end of the method, after all parameters have been validated. Previously, bad parameters would cause us to throw and abandon an unclosed ResultSet.
• Rework CachedResultSetBuilder and callers to always provide column types. Callers must provide a list of ColumnInfos (which most callers already had) or ResultSetMetaData (which other callers had).

Tasks 📍

• Manual Testing
• Verify Fix

[labkey-jeckels]

Glad to be able to view the list of pipeline protocols without being bothered by that logging.