🐛 Accept prerelease tags in release validator#14
Merged
Conversation
- Tag validation previously required exact match between tag version and pyproject.toml version, which broke the documented dry-run flow: v0.1.0rc1 against pyproject.toml=0.1.0. - Now tags are accepted when they either match pyproject.toml exactly (final release) or are a prerelease (a/b/rc suffix) of the version declared in pyproject.toml. - Keeps the intent: pyproject.toml is the source of truth for the target version; prerelease suffixes are dry-run variants of it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the tag validator in the release workflow to accept prerelease tags (
rc,a,b) as valid dry-runs of thepyproject.tomlversion. Previously the validator required exact equality, which broke the documented TestPyPI dry-run flow (e.g. tag `v0.1.0rc1` against `pyproject.toml` version `0.1.0`).Details
Discovered by pushing `v0.1.0rc1` immediately after #13 merged and watching the validator fail.