Conversation
…acts After adding SONAME via set_target_properties, CMake installs the shared library as a versioned file with liblbug.dylib/.so as a symlink. Moving the symlink without its target breaks artifact collection on macOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the commit, cmake --install would install liblbug.dylib as a real file. After adding VERSION/SOVERSION via set_target_properties, CMake now installs it as:
The workflow mv install/lib/liblbug.dylib . moves the symlink without its target, resulting in a broken symlink. The fix is to copy the versioned dylib and rename it, or copy the real file instead of the symlink.