Conversation
|
✨ Thanks for the PR! ✨ This is a friendly automated reminder that the maintainers won't look at your PR until you've properly completed all of the checkboxes in the pre-filled template. |
Contributor
Author
|
I reckon as part of this we can/should rename the other triggers inside OnAttack, so we can better differentiate between an attack round, an attack swing, things that hit, etc. |
Contributor
Author
|
The new listener should probably be MELEE_SWING_HIT, or somesuch |
532be01 to
657b90c
Compare
Contributor
Author
|
RIP DarkstarProject/darkstar#6424, at last |
Xaver-DaRed
approved these changes
Dec 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Steps to test these changes
Use it
NOTE: The swing count is 0-indexed, so it'll crit on swing 12, and then wrap around
Closes #4819