Skip to content

[core, Lua] Implement Tredecim Scythe#4823

Merged
zach2good merged 1 commit intobasefrom
tredecim_scythe
Dec 6, 2023
Merged

[core, Lua] Implement Tredecim Scythe#4823
zach2good merged 1 commit intobasefrom
tredecim_scythe

Conversation

@zach2good
Copy link
Contributor

@zach2good zach2good commented Dec 5, 2023

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  • Adds script for tredecim_scythe, with new MELEE_SWING listener
  • Adds MELEE_SWING listener trigger
  • Adds CLuaAttack wrapper and bindings for getting/setting critical flag of CAttack

Steps to test these changes

Use it

NOTE: The swing count is 0-indexed, so it'll crit on swing 12, and then wrap around

image

Closes #4819

@github-actions
Copy link

github-actions bot commented Dec 5, 2023

✨ Thanks for the PR! ✨

This is a friendly automated reminder that the maintainers won't look at your PR until you've properly completed all of the checkboxes in the pre-filled template.

@zach2good
Copy link
Contributor Author

I reckon as part of this we can/should rename the other triggers inside OnAttack, so we can better differentiate between an attack round, an attack swing, things that hit, etc.

@zach2good
Copy link
Contributor Author

The new listener should probably be MELEE_SWING_HIT, or somesuch

@zach2good
Copy link
Contributor Author

RIP DarkstarProject/darkstar#6424, at last

@zach2good zach2good added the enhancement New feature request label Dec 6, 2023
@zach2good zach2good merged commit 23de8d3 into base Dec 6, 2023
@zach2good zach2good deleted the tredecim_scythe branch December 6, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🔨 Tredecim Scythe's hidden effect not implemented

2 participants