[lua, sql] Soulflayer family adjustments#9343
[lua, sql] Soulflayer family adjustments#9343CriticalXI wants to merge 1 commit intoLandSandBoat:basefrom
Conversation
|
PLD needs a magical only stoneskin effect for the era module, thought I'd write the non-module use case for this effect as well for LSB. |
| then | ||
| allyCount = allyCount + 1 | ||
| end | ||
| end |
There was a problem hiding this comment.
In general, this looks like bad juju, iterating over every single mob in a zone.
At least add the check for
if allyCount == 3 then
break
endinside the loop to stop itterating when not necesary
| end | ||
|
|
||
| -- Add immortal shield if below max stacks | ||
| if shield < 2 then |
There was a problem hiding this comment.
If the mob changes animationSub when using immortal shield, you could just check that
| table.insert(tpList, xi.mobSkill.IMMORTAL_SHIELD) | ||
| end | ||
|
|
||
| -- Add immortal mind if there are 3+ allies within 10 yalms |
There was a problem hiding this comment.
By allies, does this mean only other soulflayers?
If so you can use mob:getParty()
There was a problem hiding this comment.
And if it includes other types, I propose
local allyCount = 0
local entityInRangeTable = mob:getEntitiesInRange(mob, xi.aoeType.ROUND, xi.aoeRadius.ATTACKER, 10)
for _, otherMob in pairs(entityInRangeTable) do
if
not entity:isPC() and
not:entity:isPet() and
entity:isAlive() and
entity:getID() ~= mob:getID()
then
allyCount = allyCount + 1
if allyCount == 3 then
break
end
end
end| } | ||
|
|
||
| -- Add mind purge only if target has dispellable effects | ||
| if target:hasStatusEffectByFlag(xi.effectFlag.DISPELABLE) then |
There was a problem hiding this comment.
Wondering if this should include target:hasStatusEffect(xi.effect.FOOD)
| table.insert(tpList, xi.mobSkill.IMMORTAL_SHIELD) | ||
| end | ||
|
|
||
| -- Add immortal mind if there are 3+ allies within 10 yalms |
There was a problem hiding this comment.
Mahjlaef observed to also use Immortal Mind while solo in era footage:
https://youtu.be/o1Gud2Xn7fg?si=vBW5c9DNHCD4ranh&t=171
Could use retail recapture check
|
This PR has been automatically marked as stale because |

I affirm:
What does this pull request do?
Sources