Skip to content

Comments

Adding Enspell Damage Percent Multiplier Effect#9502

Closed
lefneer311 wants to merge 4 commits intoLandSandBoat:basefrom
lefneer311:base
Closed

Adding Enspell Damage Percent Multiplier Effect#9502
lefneer311 wants to merge 4 commits intoLandSandBoat:basefrom
lefneer311:base

Conversation

@lefneer311
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

This adds enspell damage % multiplier calculations, including the base effect from RDM JA Composure to battleutils.cpp, wires up the augment for enspell damage %+, and adds the modifier entries to mod.lua and modifier.h.

Steps to test these changes

Switch to RDM main (level 50+), use an enspell, engage a target and note the additional effect damage
Activate composure, engage a target and note the additional effect damage is 3x (+200%)
Use !additem with the augment ID 899 for +enspell dmg % on items and equip them
Note the additional effect damage multiplier scale

@lefneer311 lefneer311 changed the title Adding Enspell Damage Percent Plumbing & Composure Multiplier Effect Adding Enspell Damage Percent Multiplier Effect Feb 20, 2026
@lefneer311
Copy link
Contributor Author

Closing and resubmitting. Comment names are too long, it seems.

@lefneer311 lefneer311 closed this Feb 20, 2026
@Xaver-DaRed
Copy link
Contributor

Do an amend. Search how to amend and force push.
Please stop closing and opening a new PR with the same changes.

@lefneer311
Copy link
Contributor Author

Do an amend. Search how to amend and force push. Please stop closing and opening a new PR with the same changes.

Will do. I was avoiding a force push because of the files being modified. Thank you, @Xaver-DaRed! #9503 will be the last PR on this topic.

@WinterSolstice8
Copy link
Contributor

force pushing on your own branch doesn't effect us so don't worry about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants