Adding Enspell Damage Percent Multiplier Effect#9502
Closed
lefneer311 wants to merge 4 commits intoLandSandBoat:basefrom
Closed
Adding Enspell Damage Percent Multiplier Effect#9502lefneer311 wants to merge 4 commits intoLandSandBoat:basefrom
lefneer311 wants to merge 4 commits intoLandSandBoat:basefrom
Conversation
Adds multipliers from enspell_dmg_pct +% items, and Composure RDM JA
Contributor
Author
|
Closing and resubmitting. Comment names are too long, it seems. |
Contributor
|
Do an amend. Search how to amend and force push. |
Contributor
Author
Will do. I was avoiding a force push because of the files being modified. Thank you, @Xaver-DaRed! #9503 will be the last PR on this topic. |
Contributor
|
force pushing on your own branch doesn't effect us so don't worry about it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
This adds enspell damage % multiplier calculations, including the base effect from RDM JA Composure to battleutils.cpp, wires up the augment for enspell damage %+, and adds the modifier entries to mod.lua and modifier.h.
Steps to test these changes
Switch to RDM main (level 50+), use an enspell, engage a target and note the additional effect damage
Activate composure, engage a target and note the additional effect damage is 3x (+200%)
Use !additem with the augment ID 899 for +enspell dmg % on items and equip them
Note the additional effect damage multiplier scale