[core, lua, sql] Enable fishing of chests for Brigand's Chart mini-quest#9507
Open
Flibe-XI wants to merge 1 commit intoLandSandBoat:basefrom
Open
[core, lua, sql] Enable fishing of chests for Brigand's Chart mini-quest#9507Flibe-XI wants to merge 1 commit intoLandSandBoat:basefrom
Flibe-XI wants to merge 1 commit intoLandSandBoat:basefrom
Conversation
5ca34fb to
f72c62b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Enables the ability to fish up chests as part of Brigand's Chart quest.
Add
GetChestPoollogic to fishingutils.cpp to enable additional chests to be added if needed.References
Captures used to determine the chest:mob ratio:
brigands_chart.xlsx
Steps to test these changes
!pos -87.5 20 -330.9 118 -- Buburimu
!additem 1873 -- Brigand's Chart
!exec player:setLocalVar('bChartActive', 1)
(or enable brigand's chart quest and test through quest logic)
/fish
Should catch chests and puffer pugil (1 mob) only, up to five chests