Skip to content

fix: ensure response_buffer cleanup in RegularRequestHandler on cancellation #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
algojogacor wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: ensure response_buffer cleanup in RegularRequestHandler on cancellation #683

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/litserve/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,7 @@ async def handle_request(self, request, request_type) -> Response:

class RegularRequestHandler(BaseRequestHandler):
async def handle_request(self, request, request_type) -> Response:
uid = None
try:
logger.debug(f"Handling request: {request}")
# Prepare request
Expand Down Expand Up @@ -360,6 +361,10 @@ async def handle_request(self, request, request_type) -> Response:
logger.error(f"Unhandled exception: {e}", exc_info=True)
raise HTTPException(status_code=500, detail="Internal server error") from e

finally:
if uid is not None:
self.server.response_buffer.pop(uid, None)

@staticmethod
def _handle_error_response(response):
"""Raise HTTPException as is and rest as 500 after logging the error."""
Expand Down
Loading